Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fix closing dialog and missing titles ...................................................................... webadmin: fix closing dialog and missing titles There must have been some infra change causing all this. Component configuring MAC pools is reused and opened in two parts of gui. At one spot it's opened via setWindow method and in another via setConfirmWindow, which is problematic since closing of such window is done inside of SharedMacPoolModel, which does not know how it was displayed. Simplest solution was to pass parameter denoting 'how to close' when cancel is clicked. Also dialog title wasn't set; changing model on which title is set fixed that. Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Bug-Url: https://bugzilla.redhat.com/1180898 Bug-Url: https://bugzilla.redhat.com/1180901 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/NewSharedMacPoolModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org