Piotr Kliczewski has submitted this change and it was merged. Change subject: bll: Hosted Engine editing validator ...................................................................... bll: Hosted Engine editing validator Adding a validator for the update Vm flow. Specifically for Hosted Engine. Currently following the below bug we want to block that by default. Future hosted engine validation can go strictly into that validator or to additional composeable constraints. Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Bug-Url: https://bugzilla.redhat.com/1305484 Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostedEngineUpdateValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/HostedEngineUpdate.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 12 files changed, 109 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Passed CI tests Shahar Havivi: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/53555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>