Einav Cohen has submitted this change and it was merged. Change subject: webadmin: clear search button resets search incorrectly ...................................................................... webadmin: clear search button resets search incorrectly Clear search button sets 'searchString' to null (instead of an empty string) when 'hasSearchStringPrefix' is true. Some affected scenarios: * Selecting an item from system tree -> clear search -> create a bookmark: bookmark's search string ends with "null" (underlying reason - CommonModel -> getEffectiveSearchString: getSearchStringPrefix() + getSearchString()). * Selecting disks main tab -> clear search -> create a bookmark: same as above. * Selecting disks main tab -> clear search: blank list - since the 'effectiveSearchString' ends with null. Change-Id: I2dfd1f51fac032df4593916c09944552a349b709 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dfd1f51fac032df4593916c09944552a349b709 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alexey Chub <achub@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com>