Moti Asayag has submitted this change and it was merged. Change subject: core: Fixed lexo-numeric comparator for big numbers ...................................................................... core: Fixed lexo-numeric comparator for big numbers The lexo-numeric comparator was using Integer class which is very limited to parse numbers, and would cause an exception if the sequence of numbers if too long. Change to BigInteger which is unlimited in size, and has the required functionality. There doesn't seem to be any adverse effect on the performance of the comparison. Change-Id: I52ec8c73e85b2505314a4043206d5883e2a43e37 Bug-Url: https://bugzilla.redhat.com/986979 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52ec8c73e85b2505314a4043206d5883e2a43e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server