Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix of NPE while creating Template from Snapshot ...................................................................... webadmin: Fix of NPE while creating Template from Snapshot Problem: Setting entity value of UnitVmModel property `isHighlyAvailable` in VmSnapshotListModel.cloneTemplate method invoked listener method VmModelBehaviorBase.updateMigrationAvailability in which NPE was thrown since `isAutoAssign` was null. This problem appeared e.g. if the snapshoted VM was highly available. Fix: Method updateMigrationAvailability() just returns if UnitVmModel is not yet fully initialized - required properties are `null`. Change-Id: I8bf28adbda195dd4d60344764ac800d9d41d3092 Bug-Url: https://bugzilla.redhat.com/1346095 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf28adbda195dd4d60344764ac800d9d41d3092 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>