Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't try to set IPs for VMs without id ...................................................................... restapi: Don't try to set IPs for VMs without id Currently the V3 adapter for VM objects tries to populate the IP addresses reported by the guest agent, but this doesn't work for VM objects that haven't been created yet, like the ones returned by the operation to import a VM from an export storage domain. In addition retrieving the details of a VM before importing it doesn't work either, because the implementation uses inheritance and generics and the JAX-RS implementation that we use in version 4 of the engine doesn't understand it. This patch fixes these two isses needed to make the import operation succeed in both versions of the API. Change-Id: I2e2ea61f34467bcbc0578fde7ba8a0fa9d12a648 Bug-Url: https://bugzilla.redhat.com/1348805 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java 4 files changed, 59 insertions(+), 66 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2ea61f34467bcbc0578fde7ba8a0fa9d12a648 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>