Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE if memory size is not set ...................................................................... webadmin: NPE if memory size is not set Problem was that even the MemorySizeParser have handled the situation correctly and returned 0, the ValueBoxBase.getValueOrThrow have overridden it to null. Fixed by creating a custom MemorySizeEntityModelTextBox which always returns the value from the parser. Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4 Bug-Url: https://bugzilla.redhat.com/1252857 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBox.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 3 files changed, 46 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org