Itamar Heim has submitted this change and it was merged. Change subject: core: possible NPE in UpdateVmDisk ...................................................................... core: possible NPE in UpdateVmDisk During UpdateVmDisk command, if the disk doesn't exist anymore in the db the private commands lists won't be initialized causing to NPE on getSharedLocks() method. Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475 Signed-off-by: Liron Aravot <laravot@redhat.com> Signed-off-by: Sergey Gotliv <sgotliv@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server