Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: update temp pgpass for non-default username
......................................................................
packaging: setup: update temp pgpass for non-default username
Current implementation creates temp pgpass file in the beginning
of the setup/upgrade flow. This causes problems when there are
already DB/username present on the system and not empty. The
setup then generates a new username/DB name, but pgpass is left
with original credentials, which causes external tools to fail.
This new implementation updates the temp pgpass file at the correct
stage so it is correct for external tools execution.
Change-Id: I22c2003ff3ccd9fa3a5ea0554518982d6302f5ba
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-remove/db/clear.py
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py
7 files changed, 49 insertions(+), 20 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/17138
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22c2003ff3ccd9fa3a5ea0554518982d6302f5ba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>