Arik Hadas has submitted this change and it was merged. Change subject: core: fix validation for adding nic to non-existing vm ...................................................................... core: fix validation for adding nic to non-existing vm There were 2 problems that prevented the right error message to be displayed in the mentioned flow: 1. we tried to get the mac-pool 2. if we do the VM validation first, we will get NPE This patch fixes it by doing a proper validation of the given vm first and only then fetch the mac-pool. Change-Id: I7fdf05f6823566e19d9136e2591b5f0127634817 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fdf05f6823566e19d9136e2591b5f0127634817 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>