Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in EventVmStatsRefresher
......................................................................
core: cleanup in EventVmStatsRefresher
1. The VM that is being created in createVmInternalData is based on the
VM from the DB, so no need to set its id.
2. The status field was set twice, removed one.
3. No need to keep backward compatibility with previous versions of VDSM
when using events, thus not set 'unknown' reason state as default.
Change-Id: I8d829cda50428e2f6f2d74ae3aaa7ec83978476d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
https://gerrit.ovirt.org/42465
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d829cda50428e2f6f2d74ae3aaa7ec83978476d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org