Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add updateSnapshot to CinderDiskParameters. ...................................................................... core: Add updateSnapshot to CinderDiskParameters. Add a new parameter called updateSnapshot. This parameter should indicate whether the snapshot should be updated or not while removing the volume. For example when we remove an image while restoring a volume the snapshot should not get updated, but when we remove a disk we definitely need to remove the volume from all the VM's snapshots. Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>