Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed useless data memebers ...................................................................... core: Removed useless data memebers The attachedDomains and isoMap members are constant empty maps. Since they are never changed, there's no point in holding them as data members. Instead, where they are used as mock return values, and inline call to Collections.emptyList() is clearer, and leaves less room for potential mistakes in the future. Change-Id: I03d3b2109ef7939cf7ad7c77f6a7b0b214b3bf67 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d3b2109ef7939cf7ad7c77f6a7b0b214b3bf67 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org