Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in AddVmCommand ...................................................................... core: cleanup in AddVmCommand - No need for both tempVar & vmDynamic fields in addVmDynamic method, thus tempVar is removed - Replaced size() > 0 with !isEmpty() - Extract parameters construction for CreateSnapshotFromTemplate command to separate method Change-Id: Idbe9402fc4dd28ac09b014027cc01a880759f360 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 31 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe9402fc4dd28ac09b014027cc01a880759f360 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server