Alona Kaplan has submitted this change and it was merged. Change subject: core: extracted method from VmInterfaceManager ...................................................................... core: extracted method from VmInterfaceManager This method does not belong into this class — it's more like dao method (or service class method). Anyways refactoring it out simplifies testing and upcoming code. Change-Id: Ibb39744bb6e0649d6e1a7ae00a36e47f04aeabb8 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/NicIsPluggedPredicate.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/FindActiveVmsUsingNetwork.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/NicIsPluggedPredicateTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/FindActiveVmsUsingNetworkTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 10 files changed, 201 insertions(+), 123 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb39744bb6e0649d6e1a7ae00a36e47f04aeabb8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>