From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: StorageJobCallback - unreported job when entity polling isn't
supported
......................................................................
core: StorageJobCallback - unreported job when entity polling isn't supported
This patch adds modifies StorageJobCallback to support handling of commands that
doesn't support entity polling (for example: Storage Domain commands) when the
executed job isn't reported by the performing host. That scenario might happen as job
are
cleared randomally from the host report.
When a job isn't reported, we can determine the job status by using entity
polling if it is supported (as the result will be determined by the entity).
If entity polling isn't supported - the callback will now assume the job has
failed so that the command will end. There is no point in continue polling
as the status isn't reflected on the entity and the job status was cleared from
the host report.
Change-Id: I6a79ef2ac1c531c97e2d5dc169c785b5567d773f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
1 file changed, 32 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit
https://gerrit.ovirt.org/65863
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a79ef2ac1c531c97e2d5dc169c785b5567d773f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>