Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: refactored host/cluster general tab mode checks ...................................................................... webadmin: refactored host/cluster general tab mode checks With the recent enhancements to form related tabs, an empty line is shown for the form items which are not added to the formpanel. For example "libvirt version" form item won't be added to formpanel if the application is not running in virt supported mode. This leaves an empty line between the previous and next row's form items. The code is refactored to make use of the setIsAvailable() method of FormItem instead leaving out the formitem itself. Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Bug-Url: https://bugzilla.redhat.com/973607 Signed-off-by: Kanagaraj M <kmayilsa@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 3 files changed, 56 insertions(+), 75 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server