From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. (
https://gerrit.ovirt.org/79984
)
Change subject: core: use engine xml according to cluster compatibility version
......................................................................
core: use engine xml according to cluster compatibility version
By not specifying any version when checking the config-value, we
essentially check the 'general' version. That is not what we want
to determine whether or not to use the engine xml by, but to check
if engine xml is enabled for the VM compatibility version instead.
Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java
3 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/79984
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>