Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add RpmVersion#hashCode ...................................................................... webadmin: Add RpmVersion#hashCode Having a class implement equals(Object) but not implement hashCode() may cause hard to debug bugs when the object used in a hashed context (e.g., placed in a HashSet or used as a key in a HashMap). Even if we do not currently use RpmVersion in such contexts, implementing it is a good defensive practice to avoid potential bugs in the future. Change-Id: I1aa6ae1b9a1f9d08d586cc156c5b68b364e4a90b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RpmVersion.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aa6ae1b9a1f9d08d586cc156c5b68b364e4a90b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>