Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Widget library enhanced
......................................................................
webadmin: Widget library enhanced
* HasWidgetLabels & WidgetLabel interfaces allowing decoupling of
(editor) widget and its label. The connection is done declaratively in
* LabelWithTooltip - implementation of WidgetLabel
ui.xml files.
* AbstractLabelableEntityModelEditor - a generic editor without label
(it doesn't inherit from AbstractValidatedWidgetWithLabel)
implementing HasWidgetLabels (similar to )
* BootstrapListBoxListModelEditor and IntegerEntityModelEditor -
editors based on AbstractLabelableEntityModelEditor
Change-Id: Ia846c34c4bfaa188a816d5654ea2425e4dea5ea7
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BootstrapListModelListBox.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/AbstractLabelableEntityModelEditor.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BootstrapListBoxListModelEditor.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/IntegerEntityModelEditor.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/HasWidgetLabels.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTooltip.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/WidgetLabel.java
8 files changed, 477 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/54320
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia846c34c4bfaa188a816d5654ea2425e4dea5ea7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>