Arik Hadas has submitted this change and it was merged. Change subject: core: simplify the creation of vm-analyzer's factory ...................................................................... core: simplify the creation of vm-analyzer's factory The factory is created by VmsMonitoring on each monitoring cycle, including cycles that were triggered by events. On large scale, the frequency can be high. Therefore, this patch removes the injections to VmAnalyzerFactory and instead the dependencies that are injected only once to the VmsMonitoring are passed to its constructor. Change-Id: I9a55c055212cac958da0fdbf86ef77bac60c20a8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 2 files changed, 63 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a55c055212cac958da0fdbf86ef77bac60c20a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;