Eyal Edri has submitted this change and it was merged. Change subject: infra: Alert/Abandon old Gerrit patches Any patch with no activity for 30 days send an email to author and cc all parties. If author not from RedHat cc iheim@ and bazulay@ by default. ...................................................................... infra: Alert/Abandon old Gerrit patches Any patch with no activity for 30 days send an email to author and cc all parties. If author not from RedHat cc iheim@ and bazulay@ by default. Any patch with no activity for 60 days abandoned with comment "Abandoned due to no activity - please restore if still relevant". Usage: alert_old_patches.py [-h] [--server SERVER] [--port PORT] [--user USER] [--key KEY] [--mail MAIL] [--cc CC [CC ...]] [--warning-days-limit WARNING_DAYS] [--abandon-days-limit ABANDON_DAYS] [--dry-run] projects [projects ...] Positional arguments: projects List of projects Optional arguments: --server SERVER Gerrit server, default: gerrit.ovirt.org --port PORT SSH Port,default: 29418 --user USER SSH User, default: $USER --key KEY SSH Key file path --mail MAIL Mail server, default: localhost --warning-days-limit WARNING_DAYS Number of days, default: 30 --abandon-days-limit ABANDON_DAYS Number of days, default 60 --dry-run Dry run --cc CC [CC ...] CC mail id's for non-redhat emails, default iheim@, bazulay@ Example: alert_old_patches.py vdsm ovirt-engine alert_old_patches.py --user alice --key ~/alice_rsa vdsm ovirt-engine Changelog: Use a global variable for the ssh command + common options. Updated all the email addresses as given in Code-review-1. Use argparse for command line options. Print return code, error and output on failures. Fixed the formatting issues with print statements. Removed all un-used global variable declarations. Specified exception type in except statements. Removed heading and trailing white spaces from doc string. Fixed all the issues given in Code-review-7. Updated the module docstring explaining what the script does. Use lowercase names for non-constant variables. Send email to owner for abandoned patches. Add an option for dry run. Add command line options to specify warning and abandon days limit. Signed-off-by: Vishnu Sreekumar <vishnu.srkmr@gmail.com> Change-Id: Ic911411a61e097c734d0199cc04057c393b974f9 --- M scripts/alert_old_patches.py 1 file changed, 163 insertions(+), 51 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Vishnu Sreekumar: Verified -- To view, visit https://gerrit.ovirt.org/37426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic911411a61e097c734d0199cc04057c393b974f9 Gerrit-PatchSet: 16 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Vishnu Sreekumar <vishnu.srkmr@gmail.com> Gerrit-Reviewer: Barak Korren <bkorren@redhat.com> Gerrit-Reviewer: David Caro <dcaroest@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Vishnu Sreekumar <vishnu.srkmr@gmail.com>