Change in ovirt-engine[master]: core: remove unneeded values of vm statistics from the database

From Arik Hadas <ahadas@redhat.com>:
Arik Hadas has submitted this change and it was merged. Change subject: core: remove unneeded values of vm statistics from the database ...................................................................... core: remove unneeded values of vm statistics from the database Saving VM statistics in a database is somewhat problematic since it is expected to change on every statistics cycle and in large-scale setups it leads to high amount of data being written to the database very frequently. Unfortunately, we cannot eliminate it completely since DWH and the dashboard get their information by querying the database directly. However, we can reduce the amount of data that is being written to the database by removing the fields that no one queries (but are taken from the cached VM statistics instead). There are currently four such fields that are removed in this patch. Together with If7206320, more than 50% of the fields that were written to vm_statistics in 4.0 are no longer written to the database. Change-Id: I1b7edbfebbb3bb83d1c1c6f08144dda269c83729 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0470_remove_uneeded_fields_in_vm_statistics.sql M packaging/dbscripts/vms_sp.sql 6 files changed, 14 insertions(+), 69 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b7edbfebbb3bb83d1c1c6f08144dda269c83729 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review