Arik Hadas has submitted this change and it was merged. Change subject: core: refactor vm jobs monitoring ...................................................................... core: refactor vm jobs monitoring 1. Rename occurrences of vm-jobs to jobs. In this context, all the jobs are supposed to be of type VmJob. 2. Rename updateVmJobs methods to processVmJobs - this name was ok in VmAnalyzer but not in this context. 3. Split saveVmJobsToDb to two methods: updateJobs and removeJobs. 4. Make processVmJobs private so it will not be called from outside of this class. 5. Extract (and simplify) the fetch of existing vm-jobs from the database into a separate method that can be mocked. Change-Id: I0833d2106ff88b7529166bb004234ac6b83c80be Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 1 file changed, 29 insertions(+), 27 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0833d2106ff88b7529166bb004234ac6b83c80be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Adam Litke <alitke@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>