Omer Frenkel has submitted this change and it was merged. Change subject: core: remove read lock of template being exported - cont ...................................................................... core: remove read lock of template being exported - cont This is a complementary patch to http://gerrit.ovirt.org/#/c/13109/ which made it possible to create a VM from template, using template provisioning of type 'clone', while the template is being exported. This patch makes it possible to create a VM from template, using template provisioning of type 'thin', while the template is being exported as well. The dontCheckTemplateImages field is removed from VmManagementParameterBase as it was set by all the flows that add VM besides invoking AddVmCommand directly. now that AddVmCommand doesn't need to check the template images as well, it becomes redundant. Instead of checking the template images, the AddVmCommand takes shared locks for the template and its disks, in a similar way to what was done in http://gerrit.ovirt.org/#/c/13109/ for AddVmFromTemplateCommand. Change-Id: I2580bc130e3b9565c8b9f515984c0180a633e3c3 Bug-Url: https://bugzilla.redhat.com/920150 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 8 files changed, 95 insertions(+), 67 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/15960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2580bc130e3b9565c8b9f515984c0180a633e3c3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server