Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80139 ) Change subject: core: Block adding disks without storage_domain ...................................................................... core: Block adding disks without storage_domain When creating a disk / disk attachment without specifying a storage domain, an error should be raised and the operation should fail. The old functionality looks for a storage domain of another disk on that VM and sets the new disk's storage domain according to it. Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97 Bug-Url: https://bugzilla.redhat.com/1476744 Signed-off-by: Shani Leviim <sleviim(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 2 files changed, 3 insertions(+), 12 deletions(-) Approvals: Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Shani Leviim: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com&gt; Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt; Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;