From Greg Sheremeta <gshereme@redhat.com>:

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix potential bug in tooltip mechanism ...................................................................... webadmin: fix potential bug in tooltip mechanism Model.java has two overloading methods for setIsChangeable: 1. setIsChangeable(boolean value) 2. setIsChangeable(boolean value, String reason) If setIsChangeable(false, "reason") is called and right afterwards setIsChangeable(false) is called, then the model is indeed not changeable, but it also has an unwanted tooltip, "reason". This patch orders the mess with these methods and their overloading ones. Change-Id: I530ddd99c4f44287d46ffab45659a61a2a526ee3 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 2 files changed, 6 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/71279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I530ddd99c4f44287d46ffab45659a61a2a526ee3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>