Sandro Bonazzola has submitted this change and it was merged. Change subject: build: fix recent pep8 warnings ...................................................................... build: fix recent pep8 warnings Fixed errors detected with pep8 1.6.2: E402 module level import not at top of file. E731 do not assign a lambda expression, use a def sorting all the imports Change-Id: I0b6ee66fb522e542e567c4024cbd8c6ad169d378 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --- M build/helptag.py M packaging/pythonlib/ovirt_engine/base.py M packaging/pythonlib/ovirt_engine/configfile.py M packaging/pythonlib/ovirt_engine/java.py M packaging/pythonlib/ovirt_engine/service.py M packaging/pythonlib/ovirt_engine/ticket.py M packaging/pythonlib/ovirt_engine/util.py M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-fence-kdump-listener/db.py M packaging/services/ovirt-fence-kdump-listener/listener.py M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/dialog.py M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine/vdcoption.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/engine_common/dwh_history_timekeeping.py M packaging/setup/ovirt_engine_setup/engine_common/postgres.py M packaging/setup/ovirt_engine_setup/firewall_manager_base.py M packaging/setup/ovirt_engine_setup/hostname.py M packaging/setup/ovirt_engine_setup/remote_engine.py M packaging/setup/ovirt_engine_setup/remote_engine_base.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-common/base/core/offlinepackager.py M packaging/setup/plugins/ovirt-engine-common/base/core/postinstall.py M packaging/setup/plugins/ovirt-engine-common/base/core/reconfigure.py M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py M packaging/setup/plugins/ovirt-engine-common/base/distro-rpm/log_setup_event.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_firewalld.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_human.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py M packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-common/base/network/process_firewalld_services.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_manual_files.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py M packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py M packaging/setup/plugins/ovirt-engine-common/base/system/mem.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/protocols.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/apache.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/environment.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/config.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py M packaging/setup/plugins/ovirt-engine-remove/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/engine.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/engine.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/protocols.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/tools.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/base/dialog/preview.py M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/base/system/environment.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/core.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/selinux.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsmi.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/tools.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/selinux.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/answerfile_fixup.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 133 files changed, 912 insertions(+), 1,047 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6ee66fb522e542e567c4024cbd8c6ad169d378 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server