Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: implement and use transport.idle(). ...................................................................... tools: notifier: implement and use transport.idle(). As part of transitioning to more then one Transport, It is no longer possible to let a transport sleep and retry for as long as it wants. that might starve other transports especially in a short notification interval. Retrying transports (those that can detect sending failures) Should implement a queue and attempt to send it on idle. This patch also fixes a bug where smtp loging is done only before the first send attempt. Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1051492 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com&gt; Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/ShutdownHook.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 8 files changed, 209 insertions(+), 110 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server