From Arik Hadas <ahadas@redhat.com>:

Arik Hadas has submitted this change and it was merged. Change subject: core: Properly handle spicevmc redirs on USB support change ...................................................................... core: Properly handle spicevmc redirs on USB support change After VM run with SPICE + USB enabled there were left several devices of type 'redirdev' which were unmanaged by the engine, and remained in the vm_device table even after the VM has been reconfigured to VNC (or USB disabled). This patch modifies the VmDeviceUtils#disableSpiceUsb to also clear the 'redirdev' SPICEVMC devices from the DB. To this end it was necessary to add new 'REDIRDEV' VmDeviceGeneralType - since the VmDeviceDao always treats the device 'type' in terms of this enum. Change-Id: Ib7013e8aa82a6b96802d37d6dcc9babffac37703 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430688 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 3 files changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7013e8aa82a6b96802d37d6dcc9babffac37703 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>