Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin,userportal: Clean up Editor fields before Model objects
......................................................................
webadmin,userportal: Clean up Editor fields before Model objects
This ensures that GWT widgets hooked to UiCommon models have
a chance to do their cleanup *before* we destroy the models.
This fixes NPEs where a model is already destroyed but a GWT
widget attempts to access its properties such as the property
change event, see AbstractUiCommandButton#cleanup for example.
Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Bug-Url:
https://bugzilla.redhat.com/1389998
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorDriver.java
2 files changed, 20 insertions(+), 20 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit
https://gerrit.ovirt.org/65899
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>