Allon Mureinik has submitted this change and it was merged. Change subject: engine: Cleaner and more robust StorageType ...................................................................... engine: Cleaner and more robust StorageType Using subtype, StorageType implemenation can be simpler, more clear, and less error prone. Adding new type should be one line change now. Change-Id: Ie05d5e85f152040d3ffbcc57333bce57fc74c616 Signed-off-by: Nir Soffer <nsoffer@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java 1 file changed, 16 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie05d5e85f152040d3ffbcc57333bce57fc74c616 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server