Allon Mureinik has submitted this change and it was merged. Change subject: Revert "core: Improve performance of getdisksvmguid" ...................................................................... Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <derez@redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server