Change in ovirt-engine[master]: core: fixed wrong hierarchy and probably invalid override

From Moti Asayag <masayag@redhat.com>:
Moti Asayag has submitted this change and it was merged. Change subject: core: fixed wrong hierarchy and probably invalid override ...................................................................... core: fixed wrong hierarchy and probably invalid override it seems, that HotUnplugNicVDSCommand wanted just to change which vds method is called, but instead altered whole execution of VdsBrokerCommand... Plus the way in which method to execute was changed was entirelly wrong. Change-Id: Ib007bcf95bd3555ea9d874b90a7f35201fbfd496 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugOrUnplugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnplugNicVDSCommand.java 3 files changed, 70 insertions(+), 64 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib007bcf95bd3555ea9d874b90a7f35201fbfd496 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review