Change in ovirt-engine[master]: webadmin: initialize TabIndexes with 1 by default

From Daniel Erez <derez@redhat.com>:
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: initialize TabIndexes with 1 by default ...................................................................... webadmin: initialize TabIndexes with 1 by default As defined at MDN [1], tabindex should be set to a positive value, as value '0' means that the element should be placed after elements with a positive tabindex. For now, this change fixes tab order in 'New Disk' dialog. I.e. when 'Size' is focused, pressing 'tab' should focus on 'Alias' (and not on search bar, as it did previously). [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex Change-Id: I91dbedee38d893302f1006c9ce1e58d146ce7cce Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91dbedee38d893302f1006c9ce1e58d146ce7cce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review