Oved Ourfali has submitted this change and it was merged. Change subject: core: Changing Directory service exception handling (#844733) ...................................................................... core: Changing Directory service exception handling (#844733) https://bugzilla.redhat.com/844733 The following patch introduces the following: a. Exception hierarchy for Directory services issues - a.1. A new DirectoryServiceException class serving base class for Engine DS exceptions a.2. Renaming EngineDirectoryServiceException to AuthenticationResultException and have it extend DirectoryServiceException b. Throwing DirectoryServiceException at GetRootDSE instead of current exception swallowing Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573 Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/AuthenticationResultException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectoryServiceException.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/EngineDirectoryServiceException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/PrepareLdapConnectionTask.java 12 files changed, 82 insertions(+), 58 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server