Arik Hadas has submitted this change and it was merged. Change subject: core: Losing graphical protocol fix ...................................................................... core: Losing graphical protocol fix The problem was that changing graphical protocol (SPICE, VNC) in setups with ConfigValues.MultipleGraphicsSupported set to false might cause to attempt to have multiple graphics devices for a while. Causes: 1. Operations of adding and removing graphics devices were not ordered. Now devices are first removed then added. 2. Methods CommandBase#canDoAction()/validate() are by default called in separate DB transaction. This causes AddGraphicsDeviceCommand validation method to not being aware of previous device removals. Fixed by @CanDoActionSupportsTransaction/ValidateSupportsTransaction. Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac Bug-Url: https://bugzilla.redhat.com/1297751 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 36 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>