Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: Clean up JobWrapper's method cache ...................................................................... core: FB: Clean up JobWrapper's method cache Cleaned up JobWrapper.execute()'s work with the method cache. Since the statement "if (cachedMethods.containsKey(methodToRun))" always evaluates to false the method cache was NEVER used. This patch enables the use of the cache and solves the NP_LOAD_OF_KNOWN_NULL_VALUE error detected by FindBugs. Change-Id: I2e6e3ae5bba5f543f7dab11309c2f7dd8d67bc00 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e6e3ae5bba5f543f7dab11309c2f7dd8d67bc00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>