Allon Mureinik has submitted this change and it was merged. Change subject: core: Rename UpdateVmDiskCommand CDA methods ...................................................................... core: Rename UpdateVmDiskCommand CDA methods Renamed shouldUpdate*Properties() methods to update*RuntimeParametersRequested() which better reflects what these methods do - they check if an update to a certain parameter was requested, they do not decide if it's appropriate (as the "should" prefix would suggest). Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server