Tal Nisan has submitted this change and it was merged. Change subject: engine: unable to label nic when nic contains a vlan ...................................................................... engine: unable to label nic when nic contains a vlan When a nic has a user defined vlan on it, it is impossible to label this nic Change-Id: I54342c0c1cc683dcdf845554b3e819921312fd2f Bug-Url: https://bugzilla.redhat.com/1241055 Signed-off-by: Marcin Mirecki <mmirecki@redhat.com> Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java 4 files changed, 43 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54342c0c1cc683dcdf845554b3e819921312fd2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: David Caro <dcaroest@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>