Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing CreateAllTemplateDisksCommand ...................................................................... core: Introducing CreateAllTemplateDisksCommand Adding CreateAllTemplateDisksCommand that creates all disks needed for creating a template. This command is called from AddVmTemplateCommand instead of calling CreateImageTemplateCommand and CloneSingleCinderDiskCommand directly. AddVmTemplateFromSnapshotCommand runs CreateAllTemplateDisksFromSnapshotCommand for the same purpose. CreateAllTemplateDisksCommand incorporates callback that is needed to poll the child commands that create disk images. The callback in AddVmTemplateCommand orchestrates the process of template creation, including post-processing of template disk images, which will be added in the next patches. Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae Bug-Url: https://bugzilla.redhat.com/1436219 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllTemplateDisksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 402 insertions(+), 149 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;