Vojtech Szocs has submitted this change and it was merged. Change subject: core: RNG device final touches ...................................................................... core: RNG device final touches This patch deals with 2 small bugs in RNG devices: 1: When creating vm from template, RNG device was created twice (firstly from AddVmFromTemplateParams and secondly from generic device copying). Solved by checking presence of RNG device on copying vm devices. 2: When creating vm pool, RNG device couldn't be customized. This was caused by incorrect RNG propagating in AddVmAndAttachToPoolCommand. 3: Fixed enum parsing in VmRngDevice. Change-Id: I78fa8f34eeebf02f14130570b581353572b18fad Bug-Url: https://bugzilla.redhat.com/977079 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Frank Kobzik: Verified Vojtech Szocs: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78fa8f34eeebf02f14130570b581353572b18fad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server