Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: Fix NPE in ConsoleProtocol
......................................................................
frontend: Fix NPE in ConsoleProtocol
This patch fixes NPE when changing VM console protocol.
The exception was caused by modifying collection that was created using
Arrays.asList() and this list implementation throws NPE when removing
elements from it.
Fixed by wrapping the list in ArrayList implementation, so that client
code can mutate the collection.
Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1109376
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/28852
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server