Tal Nisan has submitted this change and it was merged. Change subject: core: Fix of "virtual" memory hot (un)plug ...................................................................... core: Fix of "virtual" memory hot (un)plug Previously engine record of current memory was updated during each attempt of memory hot (un)plug if the vm was in state PoweringUp (probably all others than Up or Down). This path changes UpdateVmCommand#hotSetMemory() method * Renamed to 'updateCurrentMemory' because it is (and was) used even if VM is not running. * If vm is not running, new value of memory is set. * Otherwise if VM is not up, old value of memory kept. * Otherwise if memory has changed, attempt to hot plug is fired to VDSM and memory is set according to result of VDSM operation. Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d Bug-Url: https://bugzilla.redhat.com/1311899 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 37 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>