Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update unregistered disks in DB on attach. ...................................................................... core: Update unregistered disks in DB on attach. Update the following changes when attaching a Storage Domain: 1. Fetch and store all the unregistered disks from the Storage Domain and filter out all the registered disks in the DB before store those disks in the unregisteredDisks table. 2. Update each unregistered disks with its VMs/Templates it is attached to 3. Add tests for OvfUtils and update existing tests of attach SD. Change-Id: Ib8dd1c484abdc48f0f195af192fe250f5cc28219 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 6 files changed, 199 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8dd1c484abdc48f0f195af192fe250f5cc28219 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>