Eli Mesika has submitted this change and it was merged. Change subject: tools : engine-config is over writing the previous values ...................................................................... tools : engine-config is over writing the previous values 'engine-config -s' is over writing the existing values with the new ones from command line. A new option to merge the new values provided with the values in the database has been added. 'engine-config -m' or 'engine-config --merge' This concatenates the new value with the exisiting value in the database. Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Bug-Url: https://bugzilla.redhat.com/1069768 Signed-off-by: Ravi Nori <rnori@redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 83 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server