Tomas Jelinek has submitted this change and it was merged. Change subject: core: refactored RoleTreeView for reababilily purposes. ...................................................................... core: refactored RoleTreeView for reababilily purposes. - so I've added two methods allowing removal all those array declarations. - I've fixed some code conventions violations, except for ... - I know, I'm exceeding limit of 120 chars per line, but that could be expected with identifiers so long as 85 chars. But I do believe this violation is for good thing. You can read this file now. Change-Id: I294e37d07a52c894e4293ca54f9cdb1003df8913 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 175 insertions(+), 234 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified -- To view, visit http://gerrit.ovirt.org/29899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I294e37d07a52c894e4293ca54f9cdb1003df8913 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server