Omer Frenkel has submitted this change and it was merged. Change subject: core: Use FixturesTool in VmDAOTest ...................................................................... core: Use FixturesTool in VmDAOTest Removed local constants and hardcoded values and used FixturesTools constants instead where those existed. Where they didn't, they were added. The fixtures.xml file was also slightly fixed to avoid naming confusion with non-unique names. Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 32 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server