Tal Nisan has submitted this change and it was merged. Change subject: frontend: add missing warning label to FcpStorageView ...................................................................... frontend: add missing warning label to FcpStorageView This patch adds the warning label that already existed in the model (selectedLunWarning in SanStorageModelBase) but was mistakenly not added to FcpStorageView before. This warning message is used to warn about adding a lun that is already a part of a storage domain. It worked with ISCSI luns, now it also works with FCP luns. Change-Id: I5d6b0392977cc228a2a71346d70a1498631ecadd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1221189 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.ui.xml 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/51721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6b0392977cc228a2a71346d70a1498631ecadd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>