Allon Mureinik has submitted this change and it was merged. Change subject: core: broad catch in LdapTemplateWrapperFactory ...................................................................... core: broad catch in LdapTemplateWrapperFactory Replaced a catch (Exception e) clause with a series of piped catches that cover all the exceptions that can be thrown in this block. Besides being a good defensive practice and cleaning up the code, this patch solves the REC_CATCH_EXCEPTION FindBugs warning for this block. Change-Id: Iea983982865d740d2ca0a852454931fb0de0ed8c Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapperFactory.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea983982865d740d2ca0a852454931fb0de0ed8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server